Re:Material Theme has been pulled from VS Code's marketplace
by joshka on Wednesday February 26, 2025 @03:07AM
(#43181741)
Can you please clarify whether the fork also suffers from the same security issues (or engage the fork's owner to ensure that it doesn't https://github.com/t3dotgg/vsc-material-but-i-wont-sue-you)
[ Parent
| on HN ]
Re:Material Theme has been pulled from VS Code's marketplace
by theobr on Wednesday February 26, 2025 @03:37AM
(#43181919)
Hi, owner of the fork here.
I did a thorough combing of the code base when I forked. Just did another audit and still not seeing anything suspicious. Gutting all of the opencollective and changelog code to be 1000% sure.
Re:Material Theme has been pulled from VS Code's marketplace
by theobr on Wednesday February 26, 2025 @03:54AM
(#43182009)
The only potential risk was the use of sanity to render a changelog. I didn't want to risk it, so I gutted that and a ton of other stuff. Just published a new, stripped down version.
https://github.com/t3dotgg/vsc-material-but-i-wont-sue-you/p...
Re:Material Theme has been pulled from VS Code's marketplace
by f272529 on Wednesday February 26, 2025 @05:12AM
(#43182404)
Ok, but did you remove something that explicitly appeared malicious? This is a key detail that I am not seeing in your comments or commit messages.
Re:Material Theme has been pulled from VS Code's marketplace
by jorams on Wednesday February 26, 2025 @07:21AM
(#43182999)
That's covered by
> I did a thorough combing of the code base when I forked. Just did another audit and still not seeing anything suspicious.
Re:Material Theme has been pulled from VS Code's marketplace
by maxloh on Wednesday February 26, 2025 @05:01AM
(#43182342)
Hi. Please do not replace the original author's copyright notice in the LICENSE file. That is a violation of the Apache License.
You could instead "append" your name to the copyright notice though, which is legal.
https://github.com/t3dotgg/vsc-material-but-i-wont-sue-you/c...
Re:Material Theme has been pulled from VS Code's marketplace
by Der_Einzige on Wednesday February 26, 2025 @11:45AM
(#43185385)
And who is going to enforce this (assuming they're American)? Oh yeah, literally NO ONE! Which is why most open source licenses are basically fraud.
Re:Material Theme has been pulled from VS Code's marketplace
by isidorn on Wednesday February 26, 2025 @03:10AM
(#43181755)
Thanks for flagging it. Our security researchers will analize it and based on their findings we might remove this one as well.
Re:Material Theme has been pulled from VS Code's marketplace
by csears on Wednesday February 26, 2025 @08:37AM
(#43183502)
s/analize/analyze/g
Re:Material Theme has been pulled from VS Code's marketplace
by theo-steiner on Wednesday February 26, 2025 @10:29AM
(#43184546)
s/g/