Re:Sparrow, a Modern C++ Implementation of the Apache Arrow ...
by quietbritishjim on Friday January 31, 2025 @11:54PM
(#42895767)
> So the answer is that the `std::move` does nothing and should be omitted
You can't assign an rvalue into an lvalue reference, precisely to avoid this sort of mistake. If this is the only overload then this just wouldn't compile (e.g. [1]). So the std::move isn't doing nothing, but yes it should be omitted. Maybe it's just a weird typo.
Re:Sparrow, a Modern C++ Implementation of the Apache Arrow ...
by tempodox on Saturday February 01, 2025 @08:56AM
(#42898292)
Indeed, I don't even have to compile it, vim (+ Syntastic) tells me as soon as it sees it:
candidate function not viable: expects an lvalue for 1st argument
Re:Sparrow, a Modern C++ Implementation of the Apache Arrow ...
by BoingBoomTschak on Saturday February 01, 2025 @04:54AM
(#42897252)
Modern C++ in a nutshell
t. C++17 dev and pain connoisseur
So the answer is that the `std::move` does nothing and should be omitted, because this function only has one overload, and that overload takes its argument by lvalue-reference.
(And as far as I can tell, `detail::array_access::get_arrow_proxy(a)` eventually just reads a member on `a`, so there's no copying anywhere)
It's a harmless mistake; I'm just surprised it wasn't caught. The authors seem pretty experienced with the language.