Re:Ask HN: What is a common PR review time at your company?
by yichi on Sunday January 12, 2025 @07:48PM
(#42678734)
Linus torvalds famously said you shouldn't rebase for shared work, it's not a clear cut thing that not knowing how to rebase is bad per se since you shouldn't be using it a lot in the first place in his philosophy, refusing to learn is a different story however.
Re:Ask HN: What is a common PR review time at your company?
by Tade0 on Sunday January 12, 2025 @08:11PM
(#42678900)
Specifically he said that changing shared history is bad - that would be the master/main branch or release branches, not e.g. your branch.
Not knowing how to rebase means that in order to stay up-to-date with a shared branch you would have to merge it each time and thus produce something akin to a spruce tree in your commit history.
I work with a guy who, until I said "calm down", would share his PR links in the team chat several times a day. He refused to learn rebase, or seemingly anything other than a standard Git workflow of checkout, commit, push, merge, repeat. He has since improved on both fronts.