Re:PR Process Is Killing Morale and Productivity
by swisniewski on Saturday November 30, 2024 @05:16PM
(#42284423)
I usually adopt a policy with my teams:
You are not allowed to complain about style in code reviews.
If it’s important enough for your to comment about, it’s important enough for you to add a linter to the build and block the build if the style isn’t met.
If it’s not worth enough of your time to add a linter, it’s certainly not worth your peer’s time to deal with comments about style.
You are not allowed to complain about style in code reviews.
If it’s important enough for your to comment about, it’s important enough for you to add a linter to the build and block the build if the style isn’t met.
If it’s not worth enough of your time to add a linter, it’s certainly not worth your peer’s time to deal with comments about style.