News for hackers. Stuff that matters.

A comment on PR Process Is Killing Morale and Productivity. Parent comment

Re:PR Process Is Killing Morale and Productivity by Leherenn on Friday November 29, 2024 @02:11PM (#42276216)
Something helpful I have seen in this situation is to require the reviewer to test the changes for long PRs, and post proofs (a screenshot, logs, ...).

Even with the best of intentions, it's easier to miss things in longer PRs, plus it gives more time for others if they want to have a look. It's not bulletproof of course, but at least it makes sure the basic functionality is working.

[ Parent | on HN ]
Re:PR Process Is Killing Morale and Productivity by rudasn on Saturday November 30, 2024 @12:56PM (#42282972)
Agree. I've made it a habit the past few years to include before/after screenshots in my PRs and sometimes a screen capture of the UI/workflow changes. Also, screenshots in the issues pages for bugs or anything UI related.

I find it makes it easier for people to see and understand the goal of your changes and helps them focus on the how in the code review.

When others do that in their PRs I can jump straight into the tests files and get a better understanding of the what is proposed (or at least start the review process in a more substantial way - get the important stuff addressed early on).

[ Parent | on HN ]