This seem to use home made cryptography, which is never a good idea. In particular it's not clear why this design with layered algorithms is needed, nor why it uses a non standard KDF.

Prefer using libsodium for the crypto, which has made sensible choices for you.

Also you are missing a MAC, which is also a bad idea

what does this provide which cannot be done with openssl, which is available for most systems?

OpenSSL should not be used for encryption of files. PGP/GnuPG should.

No, PGP isn't much better.

Why not?

Last I checked, there's no authenticated encryption option in the OpenSSL CLI.

GnuPG and PGP are a shit show. Just make an encrypted drive volume instead.

How would you compare this to existing tools in the space like https://github.com/FiloSottile/age?

Seems like age has multiple implementations (rust, go), has a permissive license, a public specification (https://github.com/C2SP/C2SP/blob/main/age.md) and the spec/core implementation is developed by someone with a history with cryptography (I don't know if you do, but there is no indication or name attached to the repo).

While many things can be built as a hobby or learning project I feel like cryptography is one of those spaces where you should be clear if it is that and if it is not you need to expressively argue its bona fides up front.

age is definitely more mature, and as you say, it should probably say somewhere that ezcrypt is still a hobby project (albeit a serious one).

Some motives (some of which may sound strange, but mattered to me):

  * Completely public domain.
  * Without any third party dependencies (not even openssl or similar).
  * Don't rely on a single cipher (low trust).
  * Extremely portable (should easily build for and run on anything from an M4 Mac to a Raspberry Pi to an old OpenWRT MIPS router with 32 MB RAM for instance).
  * Should be easy to use (e.g. no key management, unless you want to), and composable in standard Unix ways (pipes etc).
  * Security focused, obviously. E.g. software architecture-wise, minimize dependencies, properly manage files, processes and secrets, etc.
  * Personally: To learn and to build something that I trust.

In a way: When the dust settles after the nuclear apocalypse, if you manage to dig out a C compiler, this is your tool. ;-)

"Don't rely on a single cipher" is an anti-goal, and a reason your hobby project won't be taken seriously. You'd be better off striking it from the list.

"Zero dependencies" is also not especially reassuring, as it implies you're using your own cipher implementations (or reference implementations).

> "Don't rely on a single cipher" is an anti-goal, and a reason your hobby project won't be taken seriously.

Why?

If unanticipated issues are discovered, end users may not receive the updates in a timely fashion if, for example, the repo owner is the only committer and they're on vacation when the next Heartbleed 0day hits.

I am confident and trust the OpenSSL and LibreSSL projects each have multiple folks capable of merging and releasing critical updates.

Amazing as he is, Filippo is a single person who presumably has human needs. If he's a Terminator, though, swell, do let me know.

Ah. I was thinking the critique was about combining different crypto methods in serial; I've heard people say this is a bad idea but have never understood why.

Mostly it's just that it doesn't accomplish anything.

> Without any third party dependencies (not even openssl or similar).

In your pursuit of "no dependencies", you made a classic blunder: making AES vulnerable to cache-timing attacks.

https://codeberg.org/ezcrypt/ezcrypt/src/commit/3268d71e80d3...

I'm not going to review the rest of your code. This is sufficient for me to recommend everyone run the other way screaming.

Thanks for having a look. The software implementation of AES is actually mostly a copy-paste of https://github.com/kokke/tiny-AES-c (see https://github.com/kokke/tiny-AES-c/blob/master/aes.c#L189 ). I have been meaning to replace and/or improve it. Even moderately modern x86 machines will always take the fast AES-NI path, though.

"mostly a copy-paste" is also known as a dependency

Look to BearSSL for inspiration for how to implement cryptography right

"also known as a dependency" - There are different kinds of dependencies. The ones I'm usually concerned with are the ones that cause you headaches when you try to get the software working on an exotic platform ten years from now. I've developed software for 30+ years, and along the way I have grown a strong disliking to external dependencies (be it Python packages, Boost C++ libraries, 3rd party C libraries or a hefty Mono or Java runtime).

Thanks for the reference to BearSSL - it appears to be very much in line with my own preferred design principles.

I recently gave building a file encryption tool a shot myself ( https://github.com/voodooEntity/go-tachicrypt ) tho i didnt implement my own crypto to be fair.

I think its always good to dive into topics if you are actually interested and lets face it, the beginning of most of the big things nowadays started somewhere in a basement or a garage.

The code isn't especially easy to follow, but is this a cascade of Serpent, Twofish, ChaCha20, and AES, all in CBC except for ChaCha, without an authenticator? With its own stream construction, that doesn't stop truncation?

That's pretty much spot on. Authentication is planned (and that should handle truncation too if I'm not mistaking): https://codeberg.org/ezcrypt/ezcrypt/issues/3

Public key signatures and ciphertext authentication are not the same thing.

No, I realize that (I was thinking that ssh-keygen could be used as a poor-man's authentication for some use cases - basically share a secret between sender & receiver that can be used to ensure that the message has not been tampered with). One of the reasons that I haven't implemented authentication yet is that I want to better understand the differences and nuances of different methods and use cases before deciding on a method. Recommendations are welcome.

Get rid of the weird cipher cascade and replace it either with XAES-GCM or ChaPoly. Do some research into how to handle large ciphertexts with a chunking construction. Use a well-defined construction; don't invent your own.

PSA: it should be obvious that it's a really dumb idea to use random new encryption tools from GitHub (sorry, author)

> it should be obvious

It should be, but a lot of developers don’t have formal security training, nor especially management which may end up selecting the contractors/developers and deciding on the technical approach.

If it’s explicitly not production ready, it should probably say so up front, not advertise itself as “strong encryption”. However painful that may be.

All good points. I intend to make it clearer: https://codeberg.org/ezcrypt/ezcrypt/issues/4

Don't use this.

It's missing a basic building block: authentication.

Unfortunately, the author hasn't spent long enough researching cryptography. (Even the briefest of research would have made this mistake obvious.)

Very good point!

I have been planning to look into authentication. I didn't need it for my use cases, yet, but as you say that should be an integral part of any serious tool. I added a ticket: https://codeberg.org/ezcrypt/ezcrypt/issues/3

In the meantime, signing and verification can be done separately, e.g. with ssh-keygen, although that is a bit inconvenient (which kind of defeats one of the key points of the tool).

You can't safely encrypt without authentication, so you do indeed need it.

For the record: The latest release of ezcrypt (v1.3.0) has poly1305 authentication. Thanks for the feedback!

It’s genuinely quite offensive to me when people come out with these half-baked encryption tools and talk about them like they’re suitable for anything other than a fun project to learn about cryptography. Do you have any idea of the harm you can cause when people believe they can rely on a tool like this and it betrays them?

I would strongly advise the author to add a big notice to this repo indicating its unfitness for purpose, then to go away and do some learning about modern cryptographic best practices. I’m not of the belief that cryptography should be some ivory tower, only touched by some chosen elite, but “don’t roll your own crypto” is an adage for a reason.

As a first step, the author should probably go read about meet in the middle attacks, as the “effectively 2^1024 bit key” claim is laughable. Authenticated encryption is also an obvious omission.

What’s the advantage over symmetric PGP encryption?

Can you use PGP in the same way (I haven't tried)? Basically, symmetric file encryption based on a secret password and optionally a secret pepper file (effectively a secret key).

Symmetric file encryption yes, key file I’m not aware of.

> Encryption is done in four layers.

What?

It's a cipher cascade. (Don't build cipher cascades.)

The idea isn't really to make the encryption stronger or to widen the key. It's a classical case of trust - if one cipher is compromised, there are others to cover for you. Also, I wanted to learn the different ciphers, and speed wasn't a top priority.

Yeah, that's why everyone writes cipher cascades. There's a reason you don't see them in any mainstream vetted cryptography. The bigger problem is that none of this is authenticated.

Why not exactly?

Don't use cryptographic software from people refusing to identify themselves.

This should be the top rated comment ;-) Sorry. I can't remedy the situation for you, though.

Have used axcrypt before; easy and portable

If it's the AxCrypt I think it is, it doesn't even run on Linux, never mind Raspberry PI or Milk-V for instance. And it's not free either. So it doesn't meet many of my requirements, unfortunately.

I'm the original author of AxCrypt. There's a new compatible iteration of it based on the original cryptography code called Xecrets, with several components. Xecrets Cli is the main fully featured command line engine, free open source GPL on https://github.com/xecrets/xecrets-cli . Xecrets Ez is a simple GUI frontend, single executable, portable. Runs on Linux, macOS and Windows. There are several more components available as nuget packages.

Very interesting! Thanks for the link, I didn't know about it and I'll have to check it out.

It still falls slightly outside of my zone of preference, though, as it's a .Net application, which limits which platforms it can be run on (I'm aiming for a tool that can readily be used on most of my devices, including on an old Raspberry Pi or a router).

Fair enough, that's a little out of main scope for Xecrets Cli.

Just for fun, I tested now to build and publish for an ARM processor running Linux (linux-arm) and the build worked fine. I don't have a device to test it on though.

So... as long as it runs Linux and has an ARM or ARM64 processor and sufficient storage & memory it could work! (It's not tiny like a pure C-program unfortunately).

Would be cool to try...!

Can actually try this for you. Will have a look over the weekend. Ping me otherwise on a GitHub issue with the same username

What's wrong with "openssl enc"?

I'm just glad you support Windows. We need more of this!

For basic file protection, this could be nice for folks who don’t want to mess with complex setups. But if you’re looking for physical security too, check out something like the iStorage datAshur PRO² at https://www.datawaysecurity.com/encrypted-flash-drivers/20-i... . It’s got built-in encryption right on the drive—no software needed, just plug and go. Sometimes the hardware route just adds that extra peace of mind!