Re:Git-absorb: Git commit –fixup, but automatic
by travisjungroth on Thursday September 26, 2024 @02:17AM
(#41655088)
It would mostly be unnecessary. The separate commits won’t matter after the PR if they’re getting squashed.
Debatably, if you’re making changes during a PR review, it could be helpful to make those changes in relevant commits. That way if someone goes through them during the PR, they get one clean “story”, rather than see the pre-PR commits and the conversation after.
Debatably, if you’re making changes during a PR review, it could be helpful to make those changes in relevant commits. That way if someone goes through them during the PR, they get one clean “story”, rather than see the pre-PR commits and the conversation after.