News for hackers. Stuff that matters.

A comment on Why some of us like "interdiff" code review systems (not GitHub). Parent comment

Re:Why some of us like "interdiff" code review systems (not ... by dietr1ch on Wednesday September 11, 2024 @12:43PM (#41513053)
Squashing is nice because it keeps the amount of commits minimal, but as mentioned in the article, it has the problem that now reviewers have to figure out what changed since their last review, which can get hard to do if the tree of changes originally proposed needed updates in dependencies of the commits they reviewed.

I really like the idea that I'm working on a tree (often a stack/list) of changes, and as the review progress I get this cross product of iterations over time like [a-better-way-interdiff-review-aka-git-range-diff](https://gist.github.com/thoughtpolice/9c45287550a56b2047c631...) showcases. In the end, the time dimension is useless after things get submitted, so the repository only gets the latest state of the change tree committed, which is simple and like the auto-squashed version you mention, but during review reviewers get to see the change tree evolve in an easy way.

[ Parent | on HN ]
Re:Why some of us like "interdiff" code review systems (not ... by pinkorchid on Wednesday September 11, 2024 @01:58PM (#41513743)
> the problem that now reviewers have to figure out what changed

That's something that the review tool can solve, and I agree that github doesn't handle it well. But other code review tools can show diffs between revisions independently of how the commits have been rebased or squashed over time.

[ Parent | on HN ]
Re:Why some of us like "interdiff" code review systems (not ... by dietr1ch on Thursday September 12, 2024 @12:40AM (#41517661)
That's part of the problem, if you are a reviewer you'll see the changes that other reviewers asked for on code that you did not want to review.

I guess this might be a problem mostly on large projects on monorepos, where different systems that interact end in the same codebase, but there's a cost to be paid too if each system has their own repo, build/test/deploy infra and independent ownership.

[ Parent | on HN ]