Re:Why some of us like "interdiff" code review systems (not ...
by trashburger on Wednesday September 11, 2024 @04:11AM
(#41509190)
By doing this, you break commit atomicity and make bisects hell. Please don’t do this. Commits aren’t perfect at first for sure, but they should be by the time you make them reviewable.
[ Parent
| on HN ]
Re:Why some of us like "interdiff" code review systems (not ...
by snatchpiesinger on Wednesday September 11, 2024 @04:33AM
(#41509332)
It's fine to break commit atomicity on feature branches. You can use git bisect --first-parent on you development/master branch.
Re:Why some of us like "interdiff" code review systems (not ...
by trashburger on Wednesday September 11, 2024 @06:33AM
(#41510002)
I completely disagree. In doing so you lose all visibility into the components and gradual evolution of the code that atomic commits provide. Same thing with squashing (which is just the worst).