Why some of us like "interdiff" code review systems (not GitHub)

Re:Why some of us like "interdiff" code review systems (not ... by aseipp on Tuesday September 10, 2024 @07:44PM (#41506787)

I keep saying this over and over but, Gerrit basically does that. :) You can see the relationships between any two patches on Gerrit, and more importantly, Gerrit shows you each patch individually. So you can see in a series A -> B -> C that yeah, B is small, let's go ahead and get that in.

Part of this is that UX has some really smart ideas like the "Attention Set". The attention set is basically "Which people need to take the next step?" Like a turn-based game. So, if you just did a review, you're not in the attention set for that patch anymore -- the author is.

That means Gerrit puts it down at the bottom of your queue in the UX. And what's at the top of the queue? Things where you are in the attention set! So it naturally groups things this way.

I didn't get into all the other really annoying papercuts with GitHub's UX, but even the pull request listing is worse than the alternatives. How do you know what state anything is in? You don't, you have to go read the whole thing.

[ Parent | on HN ]

Re:Why some of us like "interdiff" code review systems (not ... by zeotroph on Tuesday September 10, 2024 @08:07PM (#41506936)

Attention Set <3 - that alone is worth another post. Gerrit really is one of the best kept dev secrets, and if you never had the luck of seeing it in person at a company where you worked at, well...

Makes me wonder what other git or dev-in-general blindspots I have.

[ Parent | on HN ]

Re:Why some of us like "interdiff" code review systems (not ... by ankitdce on Wednesday September 11, 2024 @04:57PM (#41515283)

Yeh, Attention Set is a game changer. We (Aviator) also took inspiration (ahem.. copied) attention set from Gerrit: https://docs.aviator.co/attentionset

[ Parent | on HN ]

Re:Why some of us like "interdiff" code review systems (not ... by deathanatos on Tuesday September 10, 2024 @08:23PM (#41507022)

I guess I missed it in your article, and I've never had the opportunity otherwise to use Gerrit. (Since Github is essentially so pervasive. I've only used that, Gitlab, and an internal review system that didn't do interdiff.)

[ Parent | on HN ]

Re:Why some of us like "interdiff" code review systems (not ... by SlySherZ on Wednesday September 11, 2024 @02:38PM (#41514084)

Do you know how to create a local branch that tracks a gerrit commit? Usually I just do git commit --amend to update gerrit, but then I lose access to my patch's history (it's still on gerrit, but I want it locally).

[ Parent | on HN ]