It was wildly successful.
You're just under the mistaken impression that the goal was to go to space cheaply or whatever.
But the success of the shuttle program pales in comparison to the SLS and Artemis.
Now they're spending more money in all the right places, without that pesky distraction of launching the thing into space.
You're way off in the wonderland considering the goals and achievements. Just remember who's the actual goal setter is. Don't fool yourself.
But so what? I don't care about that measure of "success". I care about reliable, reusable, cost-efficient space launches, and all the technological and scientific advances that can bring. By those measures, the space shuttle was a disaster of a failure. That's what we care about.
In other words, a lot of such government-backed projects utterly fail in their objectives, not so much due to lack of prophetic foresight, but due to inability to re-evaluate when it becomes clear that the previously chosen approach can no longer lead to the envisioned outcome. ITER is another fine example of this.