Although this is for piano, your scale at the bottom looks like a really wonky piano keyboard. The black keys are actually all the white keys. Unless this is for a harpsichord, but I digress. It does show that you haven't decided whether a sharp or flat would refer to the note name or its position. If it was numbers at the bottom, it would indeed mean something different than if it has the alphabetic note names there, as it does. That shows very well what at least one of the problems with this chart is.
The way this is laid out means you are constantly doing multiple translations in order to learn a scale.
The reason for the notes being black is because I have a B&W laser printer and it was the best way for me to create something distinct and visible next to the piano keys.
It might be helpful to put a flat sign or sharp sign in the dots to really drive it home, too. That way you don't have to reference the blacked keys so often.
Since you're using it to learn piano, it seems confusing to me that your scale notes look like black keys, which are all flats on the piano. Wouldn't it make more sense to have a piano octave skeuomorph there?