News for hackers. Stuff that matters.
Re:Stripe's Monorepo Developer Environment by shepwalker on Monday August 19, 2024 @11:09AM (#41291696)
Hi! I work at Stripe on this. What're you curious about?
Re:Stripe's Monorepo Developer Environment by spacemonkey92 on Tuesday August 20, 2024 @12:19AM (#41296758)
When you are working on a large monolith, how exactly do you managed pull request?

Are they split into git-sub modules/ frameworks? Curious to know the development code review flow.

Re:Stripe's Monorepo Developer Environment by shepwalker on Tuesday August 20, 2024 @07:41AM (#41299064)
PR's are not split into submodules/frameworks for distinct review purposes. Functionally though, right now we have three distinct monorepos (not very 'mono' but we're working on it!), that represent our three main development stacks.

In our PR tooling, there's nothing that enforces/encourages scoping changes to a specific subset of any given repo. We generally encourage smaller PRs as a best practice, but a huge chunk of the benefit of a moonorepo is folks can make cross-cutting changes if/when necessary.

We have some custom goo on top of Github that manages the review flow. Specifically, we try to make it easy for folks to farm out reviews to the teams that own the code you're editing, so they don't have to hop in Slack and track down reviewers.