Re:Just open sourced my 10k LOC PHP & MySQL invoicing app
by renownedmedia on Monday June 18, 2012 @05:07PM
(#4128556)
The arguments to controller methods (in CI) are passed through some regular expressions. CI goes as far as to destroy all GET variables (which I highly disagree with).
[ Parent
| on HN ]
Re:Just open sourced my 10k LOC PHP & MySQL invoicing app
by mmmooo on Monday June 18, 2012 @05:10PM
(#4128570)
GET's are all removed (by default), but for uri segments you'll just get some character filters, and some anti-xss attempts (assuming you have that on). Nothing anywhere near sufficient to prevent sql injection. Again, didn't dig too deep, but I don't see any validation that would prevent me from doing some level of at least blindsql..
Re:Just open sourced my 10k LOC PHP & MySQL invoicing app
by renownedmedia on Monday June 18, 2012 @05:40PM
(#4128718)
I would be excited to see an example exploit executed against the app, I've tried plenty of times without success.
Any pull request to fix a vulnerability will be happily accepted!
Re:Just open sourced my 10k LOC PHP & MySQL invoicing app
by rokhayakebe on Monday June 18, 2012 @05:39PM
(#4128705)
I think CI rejects anything in the URI which isn't alpha-numeric. Would that solve the issue?
Re:Just open sourced my 10k LOC PHP & MySQL invoicing app
by mmmooo on Monday June 18, 2012 @05:54PM
(#4128794)
Kind of, anything in permited_uri_chars is allowed. This includes spaces, slashes, commas, %, and a handful of others by default. As I said only skimmed quickly so maybe I'm missing it. Will take a deeper look in a bit once not on mobile.
Re:Just open sourced my 10k LOC PHP & MySQL invoicing app
by renownedmedia on Monday June 18, 2012 @05:55PM
(#4128806)
This is the escaping mechanism I was using.