Re:I redesigned Hacker News (But I used the API this time)
by gabrielsroka on Wednesday July 10, 2024 @11:05AM
(#40927716)
I like some of it, but:
1. it's really slow.
2. it made 30 requests to load 2 comments, including fetching the same url 5 times.
3. you call the APIs in serial, but you can (should) do it in parallel.
4. you're using async=false on `xmlhttp.open("GET", filePath, false);`. this is a bad practice. also, consider using `fetch` which is a more modern API.
5. you can omit `?print=pretty` and the fetch will be smaller, probably parse faster, etc.
1. it's really slow.
2. it made 30 requests to load 2 comments, including fetching the same url 5 times.
3. you call the APIs in serial, but you can (should) do it in parallel.
4. you're using async=false on `xmlhttp.open("GET", filePath, false);`. this is a bad practice. also, consider using `fetch` which is a more modern API.
5. you can omit `?print=pretty` and the fetch will be smaller, probably parse faster, etc.
6. the back button doesn't work
compare my version (which does much less, but does it faster) https://github.com/gabrielsroka/gabrielsroka.github.io/blob/... and https://gabrielsroka.github.io/hn.html?small