1. You're right! Will fix it to handle this as well as the support for relative directories
2. Yes, Will integrate a logging library instead of fmt (https://github.com/uber-go/zap)
What if I don't use zap?
Ideally you want to add an option via a function or interface:
func New(optOne bool, log func(string, ...any)) {
if log == nil {
log = func(m string, a ...any) { fmt.Printf(m, a...) }
}
log("starting; optOne=%v", optOne)
}
Or something along those lines.
Re:Show HN: WAL Implementation in Golang
by philosopher1234 on Tuesday July 09, 2024 @02:11AM
(#40912964)
This is what log/slog is for!
What if I don't use slog?
Re:Show HN: WAL Implementation in Golang
by derekperkins on Tuesday July 09, 2024 @11:17PM
(#40923381)
Change and use slog with the zap adapter
FYI, Go already has a structured logging package called [slog](https://go.dev/blog/slog) in the standard library since V1.21.
Re:Show HN: WAL Implementation in Golang
by while1malloc0 on Wednesday July 10, 2024 @11:54AM
(#40928273)
Based on the child thread about zap vs slog I think I might not have been clear in my phrasing. The issue isn’t the specific functions used to print to the screen, it’s that library code is doing it at all. As the user of a library, I don’t want that library printing things to the screen if I don’t explicitly tell it to; decisions on logging/printing text to the screen are the responsibility of the person writing the end-user application code, not the library author. If the library author feels really strongly about printing stuff on the screen, they should make that behavior opt in, either with a configuration option or by providing some other mechanism that gives the user as much control over that behavior as possible (hence my example of throwing printing behavior into a user-supplied io.Writer)
1. The rebuf.Init function panics. I almost never want a library to call panic, and when it does, I want the library function to denote that. The convention I’ve seen most often is to start the function name with Must, so MustInit instead of Init. In this case though, I think it’d be safe to be a little more lenient in what you accept as input and trim the trailing slash.
2. I never (not almost, actually never) want library code to call any of the fmt.Print functions unless the library is explicitly for writing output, or that behavior is strictly opt in. If the library really must print things, it should take a user supplied os.Writer and write to that. Let the user control what gets printed or not.