News for hackers. Stuff that matters.
Re:Code Reviews Do Find Bugs by Izkata on Tuesday July 02, 2024 @12:55PM (#40858412)
> Set up your tooling to make the process smooth.

> Leverage automation. Run [..] linters, static checkers [..]

These don't make the process smooth unless you set them up to simply give a warning rather than block the build/merge. And with that they'll likely get ignored anyway.

I think linters/etc should be avoided until you already have buy-in from the team.

Re:Code Reviews Do Find Bugs by azov on Tuesday July 02, 2024 @02:34PM (#40859270)
It depends. If your codebase is already free of lint warnings - adding a blocking check to prevent new ones is no big deal. But if your blocking check means that everyone has to drop everything and spend a week fixing code - of course this won't be smooth.

PS. Also, it’s a good idea to have manual override for whatever autoblocks you set up. Most linters already come with this feature.

Re:Code Reviews Do Find Bugs by ElevenLathe on Wednesday July 03, 2024 @11:19AM (#40866822)
IME even better than linters is something like `go fmt` (I work mainly in Python and use https://github.com/psf/black). Rather than forcing you to manually jimmy the code to satisfy the robot, just let the robot make it look the way it wants.