News for hackers. Stuff that matters.
Re:Code Reviews Do Find Bugs by alex_lav on Monday July 01, 2024 @08:45PM (#40852462)
Code reviews can find bugs.

More often, code reviews become opportunities for team members to bikeshed. Worse, an opportunity for a non-team member to exert power over a project.

Re:Code Reviews Do Find Bugs by spankalee on Monday July 01, 2024 @08:50PM (#40852493)
Bikeshedding in a team can be good. If you're all painting the shed, it helps to agree on the color.

More generally, code review is a great opportunity for incrementally gaining or encouraging alignment across the team.

What the team chooses to align on and how strongly are left up to it, so hopefully they choose to not get bogged down in inconsequential details, but completely skipping the pretty cheap chance for reenforcing all kinds of cohesion would be a big mistake in my opinion.

Re:Code Reviews Do Find Bugs by alex_lav on Monday July 01, 2024 @09:02PM (#40852577)
You're making a lot of positive-upsided assertions about code review. My point is there is too much opportunity for negative behavior. It's the same as everything in tech, in life, "It can be good if everyone does their part to keep it good". And yet, most don't.
Re:Code Reviews Do Find Bugs by spankalee on Monday July 01, 2024 @09:10PM (#40852621)
"most don't" is a strong claim. In my experience, core review has been undoubtedly good. I would never run or join a company without it.

I'm writing code solo for the moment, and code review is maybe the thing I miss the most.

Re:Code Reviews Do Find Bugs by alex_lav on Monday July 01, 2024 @09:17PM (#40852648)
> "most don't" is a strong claim.

I'm happy to be reasonable. I guess my greater feeling is that most devs aren't great at identifying when they should identify restraint. For the same reason that most devs are abysmal interviewers, I think devs forget that code review is ultimately a human endeavor. Give your average dev the smallest amount of power and not enough guardrails and legitimate silliness ensues.

> I'm writing code solo for the moment, and code review is maybe the thing I miss the most.

I feel as though "code review" is taking on too many meanings in this conversation. Code review in the form of a second (or more) qualified dev reading and commenting on code for the greater good? Obvious good. Code review in the form of github PRs at a non-FAANG company? Skip it. Kangaroo court.

Re:Code Reviews Do Find Bugs by sadops on Monday July 01, 2024 @10:39PM (#40853077)
Maybe you just need more senior team members. Have we all forgotten that people have different levels of skill?
Re:Code Reviews Do Find Bugs by alex_lav on Tuesday July 02, 2024 @12:58AM (#40853684)
Senior team members are usually the worst offenders.
Re:Code Reviews Do Find Bugs by sadops on Monday July 01, 2024 @10:38PM (#40853076)
From where I sit, it's usually the people writing the bugs who are so averse to code reviews.
Re:Code Reviews Do Find Bugs by alex_lav on Tuesday July 02, 2024 @11:04AM (#40857375)
Everyone that writes software writes bugs.
Re:Code Reviews Do Find Bugs by 29athrowaway on Monday July 01, 2024 @09:20PM (#40852666)
Code reviews can be an opportunity for sabotaging performance or for dominance. I have seen it numerous times.

Conspiracies to delay code reviews for high performers in stacked ranking organizations is common.

They can also be ruined by having the not rotating the reviewer role among eligible reviewers in the team, in that case, everything just represents the opinion of a specific group.