News for hackers. Stuff that matters.
Re:Understanding React Compiler by naught0 on Friday June 28, 2024 @09:34AM (#40820491)
Personally, I semi-regularly encounter instances where this rule must be ignored else I achieve an infinite re-render loop. Other times, it can be ignored, like when you use a stable value in the body of the memo or effect, like state setters from `useState`.

In practice this leads to ignoring the rule, disabling the rule with a comment (and potentially forgetting to add vital dependencies when the function is updated), or adding a bunch of unnecessary noise to the dep array.

Re:Understanding React Compiler by jhardy54 on Friday June 28, 2024 @09:59AM (#40820668)
Can you give an example? In my experience these cases are often trivial to fix, and React provides some solid documentation on how to solve these: https://react.dev/learn/removing-effect-dependencies

There absolutely might be cases that can’t be solved, so I’m hoping to break out of my bubble and learn what they are!

Re:Understanding React Compiler by beedrillzzzzz on Friday June 28, 2024 @02:16PM (#40823379)
Fairly common: triggering a side-effect that uses some state value, only when a different piece of state changes.

useEffect(() => { doSomething(someState) }, [otherState])

Re:Understanding React Compiler by jhardy54 on Friday June 28, 2024 @03:12PM (#40824045)
Sorry, there might be a misunderstanding —- I’m looking for an example of when the dependency array needs to be [], is that what you posted?
Re:Understanding React Compiler by beedrillzzzzz on Friday June 28, 2024 @03:51PM (#40824560)
Yeah maybe I didn’t follow exactly, I meant this as a common example of when the hook dependencies rules must be ignored.
Re:Understanding React Compiler by naught0 on Friday June 28, 2024 @05:25PM (#40825441)
The example supplied is what I was trying to get at.

An empty dependency array means that the effect runs only once on mount. Same with memos and callbacks -- the value should remain stable. Here's a real world example of how I populate some state based on url query params:

https://github.com/Naught0/combinator/blob/master/frontend/s...

I may end up using a more robust routing solution to keep in sync with query params if I ever want to spend the effort, but this is a naive solution that works alright.

A more simplified, generic example could be:

  const [foo, setFoo] = useState();
  useEffect(() => {
    setFoo("bar");
  }, []); // The eslint rule wants setFoo here despite the value being stable