News for hackers. Stuff that matters.

A comment on Why curl closes PRs on GitHub.

Re:Why curl closes PRs on GitHub by rany_ on Wednesday June 12, 2024 @10:08AM (#40658346)
Couldn't they just edit the PR branch directly? When I make PRs I have an option "Allow edits by maintainers" which I assume would give them write access to my branch?

Edit: "We COULD but we won’t" actually addresses that, but it just wasn't obvious to me that they were referring to that feature. I can't delete this comment anymore.

[ Parent | on HN ]
Re:Why curl closes PRs on GitHub by corytheboyd on Wednesday June 12, 2024 @10:42AM (#40658749)
They explicitly call out not wanting to do this in the blog post.
[ Parent | on HN ]
Re:Why curl closes PRs on GitHub by rany_ on Wednesday June 12, 2024 @11:24AM (#40659149)
I didn't notice that they were referring to that feature, it's too late to delete my comment now...
[ Parent | on HN ]
Re:Why curl closes PRs on GitHub by corytheboyd on Wednesday June 12, 2024 @11:54AM (#40659527)
No worries, I won’t tell anyone :p
[ Parent | on HN ]
Re:Why curl closes PRs on GitHub by phoenix616 on Wednesday June 12, 2024 @06:54PM (#40664077)
Besides what they mentioned in the blog post you also can't push to PR branches owned by organizations on GitHub without getting manually added to the fork repo.
[ Parent | on HN ]