Re:Code reviews don't usually find bugs
by AnimalMuppet on Tuesday May 14, 2024 @03:47PM
(#40359359)
I worked at a place where we wrote the test before the code that implemented the functionality. We wanted to see the test fail, so that we knew it actually tested what we thought it did. Then we wrote the code that would make it pass, and verified that the test now passed.
Re:Code reviews don't usually find bugs
by pavel_lishin on Tuesday May 14, 2024 @10:38PM
(#40362518)
I definitely do this when fixing bugs - features are harder to do this for, because a lot of code that's written is exploratory.
My friend, who do you think writes the tests, and how do you think they get into the system?
Often we're writing new functionality. There are no tests for it, so they're part of the pull request, and must be reviewed to make sure they're actually testing the right thing!