Hmm, how would that look like? Like this?
if ((val < min) || (val >= max)) {
__builtin_unreachable();
}
switch (val) {
...
}
I haven't actually tried that, but if it works as intended it would actually be better yeah (not really in the case where I'm using it, because I'm switching on an integer, not an enum).More like:
switch (e) {
case A:
foo(); break;
case B:
bar(); break;
}
std::unreachable();
instead of: switch (e) {
case A:
foo(); break;
case B:
bar(); break;
default:
std::unreachable();
}
The former is more likely to produce a warning if there is an enumeration C that you forgot to handle, or you added an enumeration C and missed a switch-case to update.edit:
duh, it's supposed to be returns here instead of breaks.
But then all case branches hit the std::unreachable. How can that work in practice?
Re:The C++ Iceberg
by gravescale on Wednesday May 08, 2024 @06:13AM
(#40296249)
I think it's supposed to be a return not a break.
yeah, thanks! I added an edit.
This also allows expressing intent: no default label means that I meant to handle all cases, and having a default means that I opted into a fallback, please don't warn. That's probably why -Wswitch-enum isn't enabled by default, too many false positives without a convenient way to suppress the warning.