Depends on your use case. Sometimes I want to send a document and not have the receiver change it at their whims. E.g. quotes for jobs. Simple attachments are great for that. Also I find some people who aren't good with tech find attachments much easier to deal with. If I send a an attachment I am 100% confident the other person can open it. No so for sharing links etc.