Case and point:
https://www.google.com/search?q=parrot+secrets+e-book
OK, that makes sense when an idea can be so easily cloned.
The original article now has a parenthetical note: (edit: if your 'trick' can be easily cloned)
I agree with the updated article and with your example. If mmaunder also conditionalizes his comment on the idea being easily cloned, we're all in agreement.
I thought that was obvious from the proposed time-frame but I made it explicit because it apparently wasn't clear enough.
If it takes a decade to clone your idea, by all means, publish all your data.
Where are they? I'm not convinced that STFU really is brilliant advice. I'm not convinced that big companies with lots of resources will jump at the chance to clone an idea just because someone has shown it can generate enough profit to make an individual financially comfortable. I'm not convinced that small companies with the skill to execute well on a clone will choose someone else's idea over one they come up with themselves.
Clones do happen, but if there's a connection between publicizing financial success and getting eaten by clones, please show me. As far as I can tell, you get clones when you get popular, regardless of information you publish.