News for hackers. Stuff that matters.
Re:The Performance Impact of C++'s `final` Keyword by Negitivefrags on Monday April 22, 2024 @02:55PM (#40117555)
See this is why I find this odd.

Is there a theory as to how devirtualisation could hurt performance?

Re:The Performance Impact of C++'s `final` Keyword by phire on Monday April 22, 2024 @04:10PM (#40119416)
Jumps/calls are actually be pretty cheap with modern branch predictors. Even indirect calls through vtables, which is the opposite of most programmers intuition.

And if the devirtualisation leads to inlining, that results in code bloat which can lower performance though more instruction cache misses, which are not cheap.

Inlining is actually pretty evil. It almost always speeds things up for microbenchmarks, as such benchmarks easily fit in icache. So programmers and modern compilers often go out of their way to do more inlining. But when you apply too much inlining to a whole program, things start to slow down.

But it's not like inlining is universally bad in larger program, inlining can enable further optimisations, mostly because it allows constant propagation to travel across function boundaries.

Basically, compilers need better heuristics about when they should be inlining. If it's just saving the overhead of a lightweight call, then they shouldn't be inlining.

Re:The Performance Impact of C++'s `final` Keyword by qsdf38100 on Monday April 22, 2024 @04:54PM (#40120402)
"Inlining is actually pretty evil".

No it's not. Except if you __force_inline__ everything, of course.

Inlining reduces the number of instructions in a lot of cases. Especially when things are abstracted and factored with lot of indirections into small functions that calls other small functions and so on. Consider a 'isEmpty' function, which dissolves to 1 cpu instruction once inlined, compared with a call/save reg/compare/return. Highly dynamic code (with most functions being virtual) tend to result in a fest of chained calls, jumping into functions doing very little work. Yes the stack is usually hot and fast, but spending 80% of the instructions doing stack management is still a big waste.

Compilers already have good heuristics about when they should be inlining, chances are they are a lot better at it than you. They don't always inline, and that's not possible anyway.

My experience is that compiler do marvels with inlining decisions when there are lots of small functions they _can_ inline if they want to. It gives the compiler a lot of freedom. Lambdas are great for that as well.

Make sure you make the most possible compile-time information available to the compiler, factor your code, don't have huge functions, and let the compiler do its magic. As a plus, you can have high level abstractions, deep hierarchies, and still get excellent performances.

Re:The Performance Impact of C++'s `final` Keyword by grdbjydcv on Monday April 22, 2024 @06:41PM (#40123388)
The “evilness” is just that sometimes if you inline aggressively in a microbenchmark things get faster but in real programs things get slower.

As you say: “chances are they are a lot better at it than you”. Infrequently they are not.

Re:The Performance Impact of C++'s `final` Keyword by EasyMark on Monday April 22, 2024 @11:16PM (#40128074)
doesn't the compiler usually do well enough that you really only need to worry about time critical sections of code? Even then you could go in and look at the assembler and see if it's being inlined, no?
Re:The Performance Impact of C++'s `final` Keyword by usefulcat on Tuesday April 23, 2024 @12:05AM (#40128378)
I find that gcc and clang are so aggressive about inlining that it's usually more effective to tell them what not to inline.

In a moderately-sized codebase I regularly work on, I use __attribute__((noinline)) nearly ten times as often as __attribute__((always_inline)). And I use __attribute__((cold)) even more than noinline.

So yeah, I can kind of see why someone would say inlining is 'evil', though I think it's more accurate to say that it's just not possible for compilers to figure out these kinds of details without copious hints (like PGO).

Re:The Performance Impact of C++'s `final` Keyword by jandrewrogers on Tuesday April 23, 2024 @12:54AM (#40128647)
+1 on the __attribute__((cold)). Compilers so aggressively optimize based on their heuristics that you spend more time telling them that an apparent optimization opportunity is not actually an optimization.

When writing ultra-robust code that has to survive every vaguely plausible contingency in a graceful way, the code is littered with code paths that only exist for astronomically improbable situations. The branch predictor can figure this out but the compiler frequently cannot without explicit instructions to not pollute the i-cache.

Re:The Performance Impact of C++'s `final` Keyword by somenameforme on Tuesday April 23, 2024 @10:05AM (#40132147)
I find the Unreal Engine source to be a reasonable reference for C++ discussions, because it runs just unbelievably well for what it does, and on a huge array of hardware (and software). And it's explicit with inlining, other hints, and even a million things that could be easily called micro-optimizations, to a somewhat absurd degree. So I'd take away two conclusions from this.

The first is that when building a code base you don't necessarily know what it's being compiled with. And so even if there were a super-amazing compiler, there's no guarantee that's what will be compiling your code. Making it explicit, so long as you have a reasonably good idea of what you're doing, is generally just a good idea. It also conveys intent to some degree, especially things like final.

The second is that I think the saying 'premature optimization is the root of all evil' is the root of all evil. Because that mindset has gradually transitioned to being against optimization in general outside of the most primitive things like not running critical sections in O(N^2) when they could be O(N). And I think it's this mindset that has gradually brought us to where we are today where need what what would have been a literal supercomputer not that long ago, to run a word processor. It's like death by a thousand cuts, and quite ridiculous.

Re:The Performance Impact of C++'s `final` Keyword by moring on Wednesday April 24, 2024 @03:51AM (#40141770)
> The second is that I think the saying 'premature optimization is the root of all evil' is the root of all evil.

The greater evil is putting a one-sentence quote out of context:

""" There is no doubt that the grail of efficiency leads to abuse. Programmers waste enormous amounts of time thinking about, or worrying about, the speed of noncritical parts of their programs, and these attempts at efficiency actually have a strong negative impact when debugging and maintenance are considered. We should forget about small efficiencies, say about 97% of the time: premature optimization is the root of all evil.

Yet we should not pass up our opportunities in that critical 3%. A good programmer will not be lulled into complacency by such reasoning, he will be wise to look carefully at the critical code; but only after that code has been identified. It is often a mistake to make a priori judgments about what parts of a program are really critical, since the universal experience of programmers who have been using measurement tools has been that their intuitive guesses fail. After working with such tools for seven years, I've become convinced that all compilers written from now on should be designed to provide all programmers with feedback indicating what parts of their programs are costing the most; indeed, this feedback should be supplied automatically unless it has been specifically turned off. """

Re:The Performance Impact of C++'s `final` Keyword by somenameforme on Wednesday April 24, 2024 @05:20AM (#40142241)
Indeed, but I think even that advice, with context, is pretty debatable. Obviously one should prioritize critical sections, but completely ignoring those "small efficiencies" is certainly a big part of how we got to where we are today in software performance. A 10% jump in performance is huge; whether that comes from a single 10% jump, or a hundred 0.1% jumps - it's exactly the same!

So referencing something in particular from Unreal Engine, they actually created a caching system for converting between a quaternion and a rotator (euler rotation)! Obviously that sort of conversion isn't going to, in a million years, be even close to a bottleneck. That conversion is quite cheap on modern hardware, and so that caching system probably only gives the engine one of those 0.1% boosts in performance. But there are literally thousands of these "small efficiencies" spread all throughout the code. And it yields a final product that runs dramatically better than comparable engines.

Re:The Performance Impact of C++'s `final` Keyword by mgaunard on Thursday April 25, 2024 @04:03AM (#40154757)
That's not how compounding percentages works.
Re:The Performance Impact of C++'s `final` Keyword by a_e_k on Tuesday April 23, 2024 @12:16AM (#40128448)
Another for the pro side: inlining can allow for better branch prediction if the different call sites would tend to drive different code paths in the function.
Re:The Performance Impact of C++'s `final` Keyword by phire on Tuesday April 23, 2024 @01:23AM (#40128773)
This was true 15 years ago, but not so much today.

The branch predictors actually hash the history of the last few branches taken into the branch prediction query. So the exact same branch within a child function will map different branch predictors entries depending on which parent function it was called from, and there is no benifit to inlining.

It also means that branch predictor can also learn correlations between branches within a function. Like when a branches at the top and bottom of functions share conditions, or have inverted conditions.

Re:The Performance Impact of C++'s `final` Keyword by hansvm on Monday April 22, 2024 @03:17PM (#40117756)
There's a cost to loading more instructions, especially if you have more types of instructions.

The main advantages to inlining are (1) avoiding a jump and other function call overhead, (2) the ability to push down optimizations.

If you execute the "same" code (same instructions, different location) in many places that can cause cache evictions and other slowdowns. It's worse if some minor optimizations were applied by the inlining, so you have more types of instructions to unpack.

The question, roughly, is whether the gains exceed the costs. This can be a bit hard to determine because it can depend on the size of the whole program and other non-local parameters, leading to performance cliffs at various stages of complexity. Microbenchmarks will tend to suggest inlining is better in more cases that it actually is.

Over time you get a feel for which functions should be inlined. E.g., very often you'll have guard clauses or whatnot around a trivial amount of work when the caller is expected to be able to prove the guarded information at compile-time. A function call takes space in the generated assembly too, and if you're only guarding a few instructions it's usually worth forcing an inline (even in places where the compiler's heuristics would choose not to because the guard clauses take up too much space), regardless of the potential cache costs.

Re:The Performance Impact of C++'s `final` Keyword by cogman10 on Monday April 22, 2024 @03:25PM (#40117822)
Through inlining.

If you have something like a `while` loop and that while loop's instructions fit neatly on the cache line, then executing that loop can be quiet fast even if you have to jump to different code locations to do the internals. However, if you pump in more instructions in that loop you can exceed the length of the cache line which causes you to need more memory loads to do the same work.

It can also create more code. A method that took a `foo(NotFinal& bar)` could be duplicated by the compiler for the specialized cases which would be bad if there's a lot of implementations of `NotFinal` that end up being marshalled into foo. You could end up loading multiple implementations of the same function which may be slower than just keeping the virtual dispatch tables warm.

Re:The Performance Impact of C++'s `final` Keyword by masklinn on Monday April 22, 2024 @03:21PM (#40117789)
Code bloat causing icache evictions?
Re:The Performance Impact of C++'s `final` Keyword by samus on Monday April 22, 2024 @03:12PM (#40117711)
Devirtualization maybe not necessarily, but inlining might make code fail to fit into instruction caches.
Re:The Performance Impact of C++'s `final` Keyword by neonsunset on Monday April 22, 2024 @06:53PM (#40123832)
Practically - it never does. It is always cheaper to perform a direct, possibly inlined, call (devirtualization != inlining) than a virtual one.

Guarded devirtualization is also cheaper than virtual calls, even when it has to do

    if (instance is SpecificType st) { st.Call() }
    else { instance.Call() } 
or even chain multiple checks at once (with either regular ifs or emitting a jump table)

This technique is heavily used in various forms by .NET, JVM and JavaScript JIT implementations (other platforms also do that, but these are the major ones)

The first two devirtualize virtual and interface calls (important in Java because all calls default to virtual, important in C# because people like to abuse interfaces and occasionally inheritance, C# delegates are also devirtualized/inlined now). The JS JIT (like V8) performs "inline caching" which is similar where for known object shapes property access is shape type identifier comparison and direct property read instead of keyed lookup which is way more expensive.

Re:The Performance Impact of C++'s `final` Keyword by ynik on Tuesday April 23, 2024 @03:13AM (#40129373)
Caution! If you compare across languages like that, not all virtual calls are implemented equally. A C++ virtual call is just a load from a fixed offset in the vtbl followed by an indirect call. This is fairly cheap, on modern CPUs pretty much the same as a non-virtual non-inlined call. A Java/C# interface call involves a lot more stuff, because there's no single fixed vtbl offset that's valid for all classes implementing the interface.
Re:The Performance Impact of C++'s `final` Keyword by neonsunset on Tuesday April 23, 2024 @03:32AM (#40129486)
Yes, it is true that there is difference. I'm not sure about JVM implementation details but the reason the comment says "virtual and interface" calls is to outline it. Virtual calls in .NET are sufficiently close[0] to virtual calls in C++. Interface calls, however, are coded differently[1].

Also you are correct - virtual calls are not terribly expensive, but they encroach on ever limited* CPU resources like indirect jump and load predictors and, as noted in parent comments, block inlining, which is highly undesirable.

[0] https://github.com/dotnet/runtime/blob/5111fdc0dc464f01647d6...

[1] https://github.com/dotnet/runtime/blob/main/docs/design/core... (mind you, the text was initially written 18 years ago, wow)

* through great effort of our industry to take back whatever performance wins each generation brings with even more abstractions that fail to improve our productivity

Re:The Performance Impact of C++'s `final` Keyword by variadix on Monday April 22, 2024 @07:42PM (#40126867)
It basically never should unless the inliner made a terrible judgement. Devirtualizing in C++ can remove 3 levels of pointer chasing, all of which could be cache misses. Many optimizations in modern compilers require the context of the function to be inlined to make major optimizations, which requires devirtualization. The only downside is I$ pressure, but this is generally not a problem because hot loops are usually tight.
Re:The Performance Impact of C++'s `final` Keyword by bandrami on Tuesday April 23, 2024 @12:51AM (#40128634)
If it's done badly, the same code that runs N times also gets cached N times because it's in N different locations in memory rather than one location that gets jumped to. Modern compilers and schedulers will eliminate a lot of that (but probably not for anything much smaller than a page), but in general there's always a tradeoff.