We have mandatory code reviews for all changes and I think it works quite well. A person making a one or two line bugfix may think it's quite innocuous but it may have a bigger impact on other parts of the system than they realize. Many eyes help reduce the likelihood of that.
Re:It Takes 6 Days to Change 1 Line of Code
by crazygringo on Thursday May 17, 2012 @06:35PM
(#3989485)
I dunno... the odd bug fix has the potential to really screw things up, when the person fixing it isn't the person who wrote it originally, or it's been months since then.
Re:It Takes 6 Days to Change 1 Line of Code
by cpeterso on Thursday May 17, 2012 @07:06PM
(#3989590)
Mozilla and Google require code reviews of all code changes.
Here are some notes about Firefox's code review process:
However, I don't see as much value in reviewing low level changes such as one liners or odd bug fixes.
Making code reviews mandatory is too much overhead and too inflexible for me.