News for hackers. Stuff that matters.
Re:It Takes 6 Days to Change 1 Line of Code by HeyLaughingBoy on Thursday May 17, 2012 @06:14PM (#3989401)
Demand, no, but often it is the best idea.

Having just (as in hours ago) been through the wringer of adding new features to a mass of spaghetti that had not been touched in 10 years, the only way I could maintain my sanity (and have some assurance beyond regression testing) that I wasn't breaking something, was to refactor the existing code and then insert my changes.

Re:It Takes 6 Days to Change 1 Line of Code by ajross on Thursday May 17, 2012 @06:41PM (#3989506)
Sure. That's the point behind refactoring, it makes changes to existing code flow more smoothly. But the case here doesn't fit that at all: the change as described was a change in configuration (that just happened to be stored in a code variable), yet it was being reviewed as if it were a new feature being added through development. That's the "cargo cult" part -- refactoring in the course of development is good. Rules demanding refactoring are bad, because they hit false positives (in this case, a high priority configuration change).