News for hackers. Stuff that matters.

A comment on Xz: Can you spot the single character that disabled Linux landlock?. Parent comment

Re:Xz: Can you spot the single character that disabled Linux... by eru on Saturday March 30, 2024 @10:14PM (#39880729)
No, not if you have any sane linter or formatter involved. They wouldn't let you get away with indenting by a single space, but only by multiples of whatever you normally use in the rest of your program.
[ Parent | on HN ]
Re:Xz: Can you spot the single character that disabled Linux... by jrockway on Saturday March 30, 2024 @11:33PM (#39881162)
I mean, some CI system should be checking that "if_code_compiles()" blocks compile somewhere. It should be an error until the CI system has that header and can test both variants.

People are really quick to add optionality like this without understanding the maintenance cost. (Every boolean feature flag increases the number of variants you need to test by 2!) Either make a decision, or check that both sides work. Don't let people check in dead code.

[ Parent | on HN ]
Re:Xz: Can you spot the single character that disabled Linux... by asddubs on Sunday March 31, 2024 @03:35AM (#39882235)
multiplies it by 2, not increases
[ Parent | on HN ]
Re:Xz: Can you spot the single character that disabled Linux... by jrockway on Sunday March 31, 2024 @01:48PM (#39886325)
yup, meant to say "a factor of 2".
[ Parent | on HN ]