News for hackers. Stuff that matters.
Re:Care by jaggederest on Wednesday March 13, 2024 @10:18PM (#39699975)
I'm going to plug my PR log level policy here: I add a tag to my PRs asking for "error level" or "debug level" or whatever in between. Then the reviewer can tune their feedback. I started doing this when I was working with a diverse group of folks with different backgrounds. I'd like it to be a standard thing.

I find that I want different kinds of feedback through the process of developing a PR, and whether it's over a day or a month matters a lot too.

That way, I can safely be obsessive about things when giving PR feedback, in the knowledge they're asking for "debug level" feedback, or give it just-the-facts review if they're just trying to get something merged that has been reviewed to hell and back.

There are no comments on this comment yet.