News for hackers. Stuff that matters.
Re:The ideal PR is 50 lines long by wrs on Wednesday February 07, 2024 @03:18PM (#39293707)
Measuring the total size of the PR seems to me to be missing a dimension, namely the commit size. What if a 600-line PR consist of 10 60-line reviewable commits? Which, if not for GitHub’s broken review UI, is what I would hope is the goal for such a thing. Then you have a reasonable amount of code to look at per commit, and all in context of the larger overall change.

There are no comments on this comment yet.