News for hackers. Stuff that matters.
Re:The ideal PR is 50 lines long by woooooo on Wednesday February 07, 2024 @02:29PM (#39293079)
5????

Please tell us more. Did 6 line commits get rejected? How did anything get done?

Re:The ideal PR is 50 lines long by stephenorr on Wednesday February 07, 2024 @03:40PM (#39294001)
Well, things did get done, but not the right things.

The rule wasn't hard and fast, but you had to have a damn good reason why you wanted to add bigger commits. Protobuf definitions didn't count, so you could get away with doing longer commits for those.

Tests were discouraged anyway ("Google just tests in production", we were told), so there wasn't a lot of that sort of thing.

Re:The ideal PR is 50 lines long by johnnyanmac on Wednesday February 07, 2024 @08:27PM (#39296703)
>"Google just tests in production", we were told

well that sadly explains a ton of little quirks Ive seen in all sorts of google software over the years. Chromecasting functions is especially egrigious and it feels like connecting/disconnecting does a different thing each time.