News for hackers. Stuff that matters.

A comment on The ideal PR is 50 lines long. Parent comment

Re:The ideal PR is 50 lines long by tomjakubowski on Wednesday February 07, 2024 @02:28PM (#39293051)
> mandated that all commits be a maximum of 5 lines, ideally fewer

Yeesh. How would you ... rename anything? Imagine a linter rule which prevents referencing a given name on more than 5 different lines of code.

[ Parent | on HN ]
Re:The ideal PR is 50 lines long by bluGill on Wednesday February 07, 2024 @03:07PM (#39293591)
Many language allow an alias name. Which means you change the name and then alias the old name to the new line - 2 line PR. Then a bunch of one line PRs to change easy use of the old name. Finally a PR to remove the alias.

Which is why I don't have such a rule and would oppose it.

[ Parent | on HN ]
Re:The ideal PR is 50 lines long by stephenorr on Wednesday February 07, 2024 @03:47PM (#39294100)
The attitude might have been something to do with the individual's SRE background. In that context, I understand the desire to ship small changesets that have a limited blast radius.

It's just not really practical for actually building software.

[ Parent | on HN ]