News for hackers. Stuff that matters.

A comment on The ideal PR is 50 lines long. Parent comment

Re:The ideal PR is 50 lines long by wk_end on Wednesday February 07, 2024 @12:31PM (#39291416)
The article also claims it's the ideal size because it minimizes reverts and ends up with PRs getting more thoroughly reviewed (based on # of comments). I think that makes for a more compelling case.
[ Parent | on HN ]
Re:The ideal PR is 50 lines long by Draiken on Wednesday February 07, 2024 @12:49PM (#39291667)
Not unless we know what those changes are.

Guess what, all typo commit fixes are <50 lines and never get reverted.

[ Parent | on HN ]
Re:The ideal PR is 50 lines long by bryanlarsen on Wednesday February 07, 2024 @12:56PM (#39291768)
I wish never, definitely have been burned by a thinko in a supposed "typo fix". But I'll give you "rarely".
[ Parent | on HN ]
Re:The ideal PR is 50 lines long by Draiken on Wednesday February 07, 2024 @01:07PM (#39291953)
Haha, that's a fair point. Cries in dynamic languages

I've definitely had code with typos consistently replicated due to auto completion, then had to fix it all later on, haha.

[ Parent | on HN ]