I'm a complete paranoid when it comes to privacy issues, and I don't see any issue with an upload that starts after I click a green check mark that, to me, means, "Hey, upload my photo, please!" There's the question of what happens to the uploaded photo on their servers when you cancel at the metadata stage, for sure, but that's a data retention question, not acquisition.
After taking a photo with your camera (or selecting one that you have stored locally), you get to a details page with a big button that says "UPLOAD" at the top right. So assuming that one does take naked photos of oneself or someone else, you'd have to confirm the upload. I only bring this up because FTA, the iOS screenshots just say "Done".
Now, if Instagram does indeed upload before you press the big green "UPLOAD" button, I'd say that's a breach in trust with the app.
You know that Instagram can load photos from your camera roll, right? "what would this nude photo look like with that filter?" is a common use-case, I'd guess. And a strong expectation that it would not be sent to an outside party as a result.
I agree with your point though that users have a responsibility to figure out the objective of the app in order to understand the context of its intended use.
Just because you and I are are thinking about security, doesn't mean most people are. And I don't even feel like this is a horrible thing for Instagram to do. It is an app specifically for uploading and sharing photos.
I totally agree with the philosophy behind your claim that users see privacy as part of a utility function where sometimes the value of the experience trumps privacy controls and it also depends on the value one attaches to the information he/she is sharing. So from that perspective, especially given the publicly accepted norm that everything on instagram is public (like in Twitter), this "privacy calculus" will probably work out in favor of Instagram's decision here. And yes, it is not a horrible thing for them to be doing either.
But it does break the trust for those who are accustomed to the connotations of certain UI features (like "Done" button and progress bar).
Instagram will get away with this, but if somebody with a less trust level was engaging in such pre-"Done" uploading activity, there would be pushback. What I fear is that the co-founder by sharing this with the developers community will encourage this behavior in other startups/apps and this will then become an industry best practice even for the shady apps (just like it did for the address book).
99% of people are probably very happy that their uploads don't take 5 minutes once they hit save. To them, it's worth the privacy "risk".