News for hackers. Stuff that matters.
Re:Password may not contain: select, insert, update, delete,... by junon on Sunday January 21, 2024 @09:12AM (#39078561)
I mean, this is a gross misunderstanding of how user input makes its way into a database safely. If you're putting out error messages like this it's a giant red flag.
Re:Password may not contain: select, insert, update, delete,... by graemep on Sunday January 21, 2024 @09:17AM (#39078611)
It is also very common not to do things right. https://www.bbc.com/future/article/20160325-the-names-that-b...

That article is a few years old now and things should have got better, but even by 2016 everyone should have known properly sanitising inputs was critical for a decade or two.

Re:Password may not contain: select, insert, update, delete,... by junon on Sunday January 21, 2024 @09:19AM (#39078630)
Right but that's not really an excuse not to do them right.
Re:Password may not contain: select, insert, update, delete,... by pixl97 on Monday January 22, 2024 @10:32AM (#39090508)
You're working at the premise backwards...

One of the systems is already wrong. The excuse not to do the system right is monetary cost of fixing the broken system.

Out of all the excuses in the world, money wins.

Re:Password may not contain: select, insert, update, delete,... by junon on Monday January 22, 2024 @11:27AM (#39091348)
EDIT: responded to the wrong comment, apologies.

I really don't understand your point. If I hash on the browser the hash is still being sent to the server. A MitM or sniffing attack can just send the hash and log in. It doesn't actually protect the user at all unless they're re-using the password elsewhere. This also assumes that you're using a seeded hash of some sort, or a multi-round hasher with settings unique to every other website. Otherwise you're still going to run into stuffing and collisions.

So for sites where the plaintext password is sensitive (password managers etc) that's important. For most sites, it's not inherently wrong not to hash passwords in the browser, though it does protect against password reuse.

I'm not saying you're wrong, I just don't think you're accurately portraying the problem you're fixing.

Re:Password may not contain: select, insert, update, delete,... by mikkom on Sunday January 21, 2024 @09:17AM (#39078610)
And top of that, password should NEVER be stored to database
Re:Password may not contain: select, insert, update, delete,... by eddd-ddde on Sunday January 21, 2024 @10:31AM (#39079311)
It's normal for them to make it to an executed SQL query.
Re:Password may not contain: select, insert, update, delete,... by duskwuff on Sunday January 21, 2024 @02:37PM (#39082107)
No, it isn't.

If a user's password leaves the web application in any form other than a hash, something nonstandard and probably bad is going on.

Re:Password may not contain: select, insert, update, delete,... by Wingy on Sunday January 21, 2024 @04:41PM (#39083358)
Hashing can be done in a stored procedure. Maybe the organization decided that it's better for the DBA to handle hashing. Nonstandard maybe but not necessarily bad.
Re:Password may not contain: select, insert, update, delete,... by duskwuff on Sunday January 21, 2024 @05:00PM (#39083538)
> Hashing can be done in a stored procedure. [...] Nonstandard maybe but not necessarily bad.

No, it's unambiguously bad. You're transmitting a cleartext password to a system which doesn't have a business need to know it, and which wasn't designed to process secret data. There's a substantial risk that the database may leak that data in some unexpected way, e.g. by logging it when an error occurs or by showing the parameter in a process list. Worse, a stored procedure can potentially be covertly modified to store or exfiltrate the password while hashing it.

Re:Password may not contain: select, insert, update, delete,... by junon on Sunday January 21, 2024 @05:41PM (#39083834)
To be clear, this only improves security if the user reuses passwords.
Re:Password may not contain: select, insert, update, delete,... by Wingy on Monday January 22, 2024 @01:58PM (#39093712)
That's true, the hashing should definitely be done as early as possible.

"As early as possible" is interesting. It could be done on the client, however you need to actually have the hash to check if a string hashes to the same as it because of the salts embedded in the strings. Using an algorithm without salting would allow you to hash the password on the client then allow arbitrary 32 (or however long your hash digests are) character strings on the server as a password equivalent. This would also protect from a misconfigured or malicious server logging unhashed passwords.

Re:Password may not contain: select, insert, update, delete,... by duskwuff on Monday January 22, 2024 @03:10PM (#39094744)
> It could be done on the client

No, that's actually too early -- if you let the client hash the password, you're vulnerable to a "pass-the-hash" attack where the client submits a hash without knowing the password.

There are protocols like SRP and other PAKEs which allow this to be done securely, but it's uncommon for them to be used in web applications.

Re:Password may not contain: select, insert, update, delete,... by Wingy on Monday January 22, 2024 @03:33PM (#39095023)
My reasoning was that if you can capture the hash, you could have also captured the password but that doesn't account for a situation where the database is compromised.
Re:Password may not contain: select, insert, update, delete,... by berkes on Tuesday January 23, 2024 @04:39AM (#39101358)
Hashing is hardly ever done client side. Most often server side, which is fine, because it's not the same as "storing plain text".

In fact, if you rely on client side hashing, you are not only making the app a lot less accessible (it will only work with JS enabled), the security is worse, because now you are publishing a salt to the client. Or you are working with unsalted hashes which is hardly better than just plain text.

SSL is what protects passwords in transit. Not some JavaScript client side hashing DIY.

Re:Password may not contain: select, insert, update, delete,... by duskwuff on Tuesday January 23, 2024 @11:38AM (#39105712)
I think you may have misunderstood me. By "the web application" I mean the application server, not client-side code.
Re:Password may not contain: select, insert, update, delete,... by junon on Sunday January 21, 2024 @09:19AM (#39078625)
Well, not in plaintext.
Re:Password may not contain: select, insert, update, delete,... by klyrs on Sunday January 21, 2024 @01:17PM (#39081034)
That's why you hash the password with an SQL built-in hash function. For security! But the password is still in plaintext inside the query so you can retrieve it from the logs for... security?

(I joke, but 20 years younger me, self-teaching php and security etc? Who knows what she'd think of this)