News for hackers. Stuff that matters.
Re:Error handling in Go web apps shouldn't be so awkward by bananapub on Tuesday January 09, 2024 @09:35PM (#38935432)
> but how do you justify incomplete

are you seriously suggesting that Go's insistence of requiring the programmer to scatter "if err != nil {}" after most function calls - with no compiler assistance if you forget - is complete either in the sense of "having all necessary parts, elements, or steps" or "being finished"?

it's terrible, causes bugs and it seems incredibly unlikely to me that it won't be improved.

Re:Error handling in Go web apps shouldn't be so awkward by randomdata on Tuesday January 09, 2024 @10:55PM (#38935940)
At very least, unless you hate other developers for some reason, you need to document in your test suite what errors are returned.

How, exactly, are going to forget a necessary `if err != nil` without your test suite blowing up?

If you do hate other developers for some reason, why not leave out some `err != nil`s to really drive home your hatred towards them?

Re:Error handling in Go web apps shouldn't be so awkward by kelnos on Wednesday January 10, 2024 @12:13AM (#38936487)
If you can forget to check an error at a call site, then you can just as easily forget to add a proper test for that error condition. I prefer writing in languages where the syntax and standard library and compiler will help me avoid mistakes, and not have to rely on tests -- more error-prone code I have to write! -- to do that for me (and yes, I understand that I will never avoid having to write some tests, but the more the language and compiler can do for me, the better).

A language with generics and sum types (so you can implement something like Either, Try, or Result) doesn't let you use the result of a fallible function call without handling the error explicitly. And if the result is unit/void, most compilers/linters will still warn you if you haven't used the Either/Try/Result type that's returned.

But ultimately it doesn't matter. Write in whatever language you feel comfortable and most productive.

Well, unless you're starting a new security-sensitive project and want to write in C. Just... stop.

Re:Error handling in Go web apps shouldn't be so awkward by randomdata on Wednesday January 10, 2024 @12:26AM (#38936568)
I don't follow. Errors are part of your functional specification. Not even a complete type system can avoid you needing to write tests to document the error conditions. We are not talking about writing tests to stand in where an incomplete type system may be lacking.

Assuming you don't hate other developers, and given the tests you would write in any language, how do you foresee missing an error branch? Again, not specifically trying to test for something that a sufficiently advanced type system would catch, just your regular level documenting that demonstrates to other developers that you don't hate them.

> then you can just as easily forget to add a proper test for that error condition

If an error condition is easily forgotten in the documentation, then who cares about the implementation thereof? It is obviously not important. In fact, it is arguable that your program is incorrect if you do handle the condition in such a case.

Re:Error handling in Go web apps shouldn't be so awkward by bananapub on Wednesday January 10, 2024 @02:42AM (#38937369)
what tool do you use to verify that every possible path your program, including all errors paths in dependencies, is executed?
Re:Error handling in Go web apps shouldn't be so awkward by randomdata on Wednesday January 10, 2024 @11:37AM (#38940422)
If you are referring to test coverage, the standard Go toolchain includes that out of the box.

But in this case you don't need to know about what paths have been executed. It will be obvious that an error path was not handled when your program does not adhere to function that is documented.

Re:Error handling in Go web apps shouldn't be so awkward by tripleo1 on Thursday January 11, 2024 @06:32PM (#38961134)
> including all errors paths in dependencies
Re:Error handling in Go web apps shouldn't be so awkward by Conscat on Tuesday January 09, 2024 @10:29PM (#38935772)
Goland and Emacs (with Tree Sitter) can at least generate those automatically for you so they won't be forgotten, fwiw.
Re:Error handling in Go web apps shouldn't be so awkward by im_dario on Wednesday January 10, 2024 @09:15AM (#38939216)
No "compiler assistance" doesn't mean no assistance at all. There is a growing set of linters based on the community-accepted analysis package [0] that prevent this and other gotchas that Go devs may be prone to.

It isn't a perfect solution, but it works at community level without needing to wait for the Go team to take care of or changing the language/toolchain.

0: https://pkg.go.dev/golang.org/x/tools/go/analysis

Re:Error handling in Go web apps shouldn't be so awkward by saturn_vk on Wednesday January 10, 2024 @10:02AM (#38939627)
> if you forget

Does this happen? Is there any data on how often error checking is forgotten?

Re:Error handling in Go web apps shouldn't be so awkward by fl0ki on Wednesday January 10, 2024 @02:11PM (#38941967)
In my experience, outright forgetting is very rare because an unused err should be a warning, but the following is not nearly as rare as it should be:

if err != nil { return nil }

With how boilerplate the correct version is, you learn to skip over it entirely, meaning it can be hard to spot that anything is wrong here. Linters do exist for this now, but they have so many false positives on other error handling cases that most people don't bother with them.