Re:TIL: Go's CompareAndSwap is not always Compare-and-swap
by dominikh on Monday January 08, 2024 @04:19PM
(#38918296)
Note that the source you're seeing there is the fallback implementation, which is only used if there is no instruction for FMA in the architecture you're compiling for. On AMD64, for example, the call to math.FMA will be replaced by the VFMADD231SD instruction.
It turns out, with some more research (https://github.com/golang/go/issues/25819), that the function was added not to guarantee performance but to guarantee precision, namely that fused mutiply and add yields higher precision than doing the operations stepwise and in certain situations you'd like to guarantee precision. Which is cool, but absolutely not what I would've guessed on first read, and the first commenter also closed the issue with the same take!
So I was able to successfully counterpoint using math.FMA() as a performance optimization and maybe a small personal takeaway to not optimize unless I really know what the thing is doing.