So the AFP failure mode I saw was that I could list a directory or two and then the finder would hang and eventually the connection would just drop. Apple's been nudging people to SMB for a while now so I'm kinda tempted to stay with Samba.

Except for the whole SMB data corruption thing that's apparently been a problem since Ventura.