News for hackers. Stuff that matters.
Re:Google takes the pain out of code reviews, with 97% dev s... by colonwqbang on Monday December 04, 2023 @05:43PM (#38524217)
Missing or misleading documentation. Confusing names. Lacking test coverage for new functionality. Unnecessarily complex code that can readily be simplified. Code that looks important but in fact does nothing useful. Unrelated changes mixed in with a patch that's ostensibly about something else.

These are all things I think are valid to point out in a code review. I don't think I would like to work in a company that rejects the notion.

There are no comments on this comment yet.