News for hackers. Stuff that matters.

A comment on Google takes the pain out of code reviews, with 97% dev satisfaction. Parent comment

Re:Google takes the pain out of code reviews, with 97% dev s... by withinboredom on Monday December 04, 2023 @05:36PM (#38524143)
How is spending 5 minutes x TEAM_SIZE to go over what you're going to do more time than 1-2 days solving a problem, then another hour or two for the reviewer to write out why it's wrong, then another day or two rewriting everything from scratch?
[ Parent | on HN ]
Re:Google takes the pain out of code reviews, with 97% dev s... by Arainach on Monday December 04, 2023 @05:57PM (#38524362)
None of those timelines are realistic:

* Most CLs don't take multiple days to write

* Reasonably-sized CLs take 5-10 minutes to review - if I have things to say. Much less if the code looks good and I don't have any requests.

* I cannot think of any CL in the last 5 years where I made a comment that caused someone to "rewrite everything from scratch". Most feedback can be done in a few clicks in an IDE which supports refactor or a few minutes of copy/paste.

[ Parent | on HN ]