Google takes the pain out of code reviews, with 97% dev satisfaction

Re:Google takes the pain out of code reviews, with 97% dev s... by zdragnar on Monday December 04, 2023 @12:27PM (#38520149)

> In my team we prefix nitpicky comments explicitly with “nit:” and it’s up to the author to decide what to do with it

This is different from what the OP is talking about.

I've worked at places where staff engineers seem to have been rated on number of comments left on PRs... they were typically somewhere between nit picky and useless, with the occasional person directly contradicting feedback they'd given in a previous PR.

Oh, and you had to address every one of them before getting approval.

[ Parent | on HN ]

Re:Google takes the pain out of code reviews, with 97% dev s... by Reubend on Monday December 04, 2023 @01:49PM (#38521326)

> I've worked at places where staff engineers seem to have been rated on number of comments left on PRs

> Oh, and you had to address every one of them before getting approval.

This just sounds horrible.

[ Parent | on HN ]

Re:Google takes the pain out of code reviews, with 97% dev s... by d0mine on Monday December 04, 2023 @02:01PM (#38521507)

> rated on the number of comments

It sounds idiotic.

It is unrelated to the question whether short-term (one PR) only reviews are preferable over reviews that recognize the reality that it is not the last PR ever and therefore more long-term view may be useful.

[ Parent | on HN ]