News for hackers. Stuff that matters.
Re:Google takes the pain out of code reviews, with 97% dev s... by marcosdumay on Monday December 04, 2023 @12:08PM (#38519899)
I've received plenty of negative feedback on the internet for this (and up to now, discarded all), but I really don't think acceptance review is the correct time for guidance.

Yes, juniors need guidance. That means you must read their code, and talk to them about it. They also need real-world feedback. They do really need you not managing all of the interaction they have with the real world. Now, what you can not manage is up for a complex risk analysis, but they really need you to get out of the way at some point.

Re:Google takes the pain out of code reviews, with 97% dev s... by johnnyanmac on Monday December 04, 2023 @01:42PM (#38521218)
So, when is the right time?
Re:Google takes the pain out of code reviews, with 97% dev s... by marcosdumay on Monday December 04, 2023 @02:10PM (#38521645)
At some time you plan for it. Preferably a calm time, not one they are waiting a decision from you.

E.g. before they start implementing a feature is better than after they finish it.