Re:Google takes the pain out of code reviews, with 97% dev s...
by iwontberude on Monday December 04, 2023 @11:55AM
(#38519688)
If you link peoples ability to use their computer by how quickly they can click "Approve" on a PR, it will definitely lead to a break down in review quality and beat you at your own personal records of latency and MTTR.
[ Parent
| on HN ]
Re:Google takes the pain out of code reviews, with 97% dev s...
by jrockway on Monday December 04, 2023 @12:03PM
(#38519809)
I'm sure there would be negative effects, but at least things would move forward quickly. This is the worst system except for all the others.
Re:Google takes the pain out of code reviews, with 97% dev s...
by yjftsjthsd-h on Monday December 04, 2023 @12:38PM
(#38520285)
Move quickly yes, move forward not necessarily. You've described a system where everybody hits approve or finds something to complain about as fast as they possibly can without worrying about little questions like whether it should have been approved or whether the changes they request are legitimate.
Re:Google takes the pain out of code reviews, with 97% dev s...
by johnnyanmac on Monday December 04, 2023 @01:55PM
(#38521420)
Sounds like you work best on a small team if that's your focus. Medoum-large ones already have a proven product (or proven experience). You don't focus on blazing gast iterations at that stage unless you are in early R&D or something evergreen.
And well, if you're primary motivation is Financial: okay, you're not being paid to move quickly. Or if you hope to move up the ladder quickly you gotta deal with the office politics. Which includes delays in communication. React to those lapses as you feel is appropriate to your goals and personality.