Google takes the pain out of code reviews, with 97% dev satisfaction

Re:Google takes the pain out of code reviews, with 97% dev s... by Eji1700 on Monday December 04, 2023 @11:48AM (#38519583)

> If you are holding up the approval because you want someone to rewrite the code the way you would have written it, get out of the way.

While I'm being pedantic here and get your point, I do think it's important that code is following proper styles.

I get that there's a bunch of nitpicky nonsense that goes into code review, but making sure it follows the same style so in 6 months when someone else has to dig through it you don't have to teach a totally different pattern/method or figure out what arcane bullshit they did is important.

And again, I'm sorta assuming this was implied but wanted to throw it out there since it's one of the most annoying things i've ever had to deal with.

[ Parent | on HN ]

Re:Google takes the pain out of code reviews, with 97% dev s... by ryandrake on Monday December 04, 2023 @12:01PM (#38519785)

Style wars are the kind of thing that should just be automated away with a source control hook that reformats all submissions.

[ Parent | on HN ]

Re:Google takes the pain out of code reviews, with 97% dev s... by wubrr on Monday December 04, 2023 @12:30PM (#38520190)

This. Any subjective style/pattern agreed to by the team should be checked and/or fixed automatically. If you don't have lint rules set up to enforce these things - go write them instead of commenting about subjective style preferences in PRs.

[ Parent | on HN ]