News for hackers. Stuff that matters.
Re:Google takes the pain out of code reviews, with 97% dev s... by jasonlotito on Monday December 04, 2023 @11:46AM (#38519566)
Yeah, it seems like Gerrit with lots of Google-specific stuff. Not surprised. Used Gerrit for 12 years, and loved it.
Re:Google takes the pain out of code reviews, with 97% dev s... by nappy-doo on Monday December 04, 2023 @11:54AM (#38519670)
Gerrit is pretty crap compared to critique. It has a workflow that works for Android, but critique is really much better.
Re:Google takes the pain out of code reviews, with 97% dev s... by cmrdporcupine on Monday December 04, 2023 @01:45PM (#38521256)
The essential thing is that Gerrit is a swiss army knife review tool for git, whereas Critique is able to be consistent and fluid because it only has to worry about working with the standard workflow in Piper/CitC (and now fig I guess)

I agree Critique is much nicer, but mostly because it's more consistent and doesn't have to deal with all the oddities of git.

Re:Google takes the pain out of code reviews, with 97% dev s... by crotchfire on Tuesday December 05, 2023 @04:30AM (#38528645)
Can you be more specific?

Gerrit does in fact impose a particular workflow: each commit is the atomic unit of review.

This, BTW, is a beautiful thing. Most of the idiocy of github is trying to have multi-commit pull requests. Then they had to bodge on that "suggested changes" nonsense instead of having proper dependency tracking between pull requests.

When each commit is the unit of review, you get pull request dependencies and recursive pull requests automatically. Instead of suggesting changes you can simply create a commit with your suggestion which has the reviewed commit as its parent. It's so simple yet so much more powerful.

Re:Google takes the pain out of code reviews, with 97% dev s... by k_dumez on Monday December 04, 2023 @04:07PM (#38523068)
What do you think Gerrit is missing compared to Critique?

Graphite[0] is also similar in that space(code review platform built on GitHub), the CLI could use some work but combined with the web UI it scratches that same itch that Critique did for me

[0] https://graphite.dev/