Re:Optimizing Go string operations with practical examples
by icholy on Sunday December 03, 2023 @06:31AM
(#38506299)
You can clean up this code by writing a package for generating JSON token by token.
w := jsonx.New(os.Stdout)
w.OpenObject()
w.ObjectKey("commit")
w.Int(0)
w.CloseObject()
Re:Optimizing Go string operations with practical examples
by costco on Sunday December 03, 2023 @12:31PM
(#38508858)
Good point. I only have the ugly code in a few places so I debated whether doing something like this would be worth it or not. It probably is.
Re:Optimizing Go string operations with practical examples
by icholy on Monday December 04, 2023 @05:06PM
(#38523834)
I only switched mine once a second dev joined the project.
Re:Optimizing Go string operations with practical examples
by kiitos on Sunday December 03, 2023 @06:57AM
(#38506431)
Be careful that you're not pooling buffers of wildly different sizes
Also this code has many many problems please never use it to encode JSON :)
Re:Optimizing Go string operations with practical examples
by costco on Sunday December 03, 2023 @12:17PM
(#38508701)
It's part of an API client I made for Resy so there are some guarantees on what characters will be in configID which is why I don't escape everything. I actually have a separate pool but I used bytebufferpool.Get instead of client.pool.Get when writing it here so the intent was clearer. But the code has gotten me Friday 7 PM reservations at Tatiana so it works though it's probably overkill because network latency is by far the biggest cost in terms of time. I probably should just have a JSON encoder write to the buffer.
Tangentially related:
Not really necessary here but lately I've been using buffer pools like the one by the fasthttp author to avoid allocating in performance sensitive places. But the code is sometimes pretty ugly.