Re:In OpenZFS and Btrfs, everyone was just guessing
by lvncelot on Thursday November 30, 2023 @07:08AM
(#38472499)
Sidenote: What a great commit message. The expanded comment explains why both checks are necessary, but the commit message gives so much more context for anyone wondering and `git blame`ing that line.
Re:In OpenZFS and Btrfs, everyone was just guessing
by solarkraft on Thursday November 30, 2023 @11:17AM
(#38475308)
Totally. Also: I've never seen Sponsored-by:
> Signed-off-by: Rob Norris <[email protected]>
> Sponsored-by: Klara, Inc.
> Sponsored-by: Wasabi Technology, Inc.
Re:In OpenZFS and Btrfs, everyone was just guessing
by emaste on Thursday November 30, 2023 @01:30PM
(#38477127)
This is a longstanding tradition from FreeBSD. A list of our commit message trailers: https://docs.freebsd.org/en/articles/committers-guide/#_incl....
"Sponsored by:" search in FreeBSD commit messages: https://freshbsd.org/?q=%22Sponsored+by%3A%22
Re:In OpenZFS and Btrfs, everyone was just guessing
by solarkraft on Thursday November 30, 2023 @05:31PM
(#38480128)
I like it! Seems like a great way to incentivise companies to contribute.
Re:In OpenZFS and Btrfs, everyone was just guessing
by throw0101b on Thursday November 30, 2023 @06:26PM
(#38480731)
> I like it! Seems like a great way to incentivise companies to contribute.
It also helps with lawsuits, which was a major thing right at the beginning of history of BSD.
* https://en.wikipedia.org/wiki/UNIX_System_Laboratories,_Inc.....
Linux later had the lawsuit issue with SCO and IBM and tracking where certain things came from (which was not helped by the fact that Linus Torvalds refused to use source code tracking for the longest time (later taking up Bitkeeper, and later developing git)).
Re:In OpenZFS and Btrfs, everyone was just guessing
by chasil on Thursday November 30, 2023 @09:16PM
(#38482200)
The beginning of BSD was the 1978 shipment of 1BSD by Bill Joy.
You likely mean the end of the effort to replace all AT&T code, which was more than a decade later.
Re:In OpenZFS and Btrfs, everyone was just guessing
by jiripospisil on Thursday November 30, 2023 @05:32PM
(#38480136)
A more "correct" fix has been posted https://github.com/openzfs/zfs/pull/15615
Re:In OpenZFS and Btrfs, everyone was just guessing
by jeffbee on Friday December 01, 2023 @10:09AM
(#38487586)
Neither of these fixes are great because neither of them include tests. This is a dataloss bug in a filesystem, no existing test covered it, and no new tests were added to demonstrate the efficacy of the supposed fix or prevent regressions.
Re:In OpenZFS and Btrfs, everyone was just guessing
by jiripospisil on Friday December 01, 2023 @10:55AM
(#38488168)
There's an ongoing work on a stress test for this. https://github.com/openzfs/zfs/pull/15608
Re:In OpenZFS and Btrfs, everyone was just guessing
by rincebrain on Friday December 01, 2023 @01:27PM
(#38490337)
There was, actually, a test, but it turns out to be rather hard to make a deterministic test to reproduce a rare race condition without sticking your fingers in at runtime and forcing the "wrong" ordering.
It looks like they managed to exactly pin down what was happening.