News for hackers. Stuff that matters.
Re:GitHub is investigating an incident with Pull Requests, I... by johnfn on Monday November 27, 2023 @04:14PM (#38438405)
Before the MS acquisition, Github didn't even have emoji reactions on comments in issue threads, so people just spammed +1s if they had the same issue. It was terrible. (You can still see evidence of this on older repos.) They also didn't have like 5 billion other features that we now take for granted.

EDIT: Sorry, this is incorrect. GH did ship them prior to the MS acquisition. I do however remember them taking an EXTREMELY long time to ship emoji reactions, which struck me as a fairly trivial feature. I stand by the point that GH ships features faster post-acquisition, though.

Re:GitHub is investigating an incident with Pull Requests, I... by Springtime on Monday November 27, 2023 @04:24PM (#38438547)
They had reactions two years prior as confirmed by their blog post[1] about it.

[1] https://github.blog/2016-03-10-add-reactions-to-pull-request...

Re:GitHub is investigating an incident with Pull Requests, I... by johnfn on Monday November 27, 2023 @04:34PM (#38438706)
Dang, you're right. Sorry about that.

I remembered that reactions irked me for some reason, but I had incorrectly tied it to the MS acquisition. The real issue was this: it took Github an extremely long amount of time to add a feature as simple as reactions. Github was founded in '08, and didn't add reactions for another eight years! But I distinctly remember once MS acquired them, they started shipping features left and right, and features much larger than simple emoji reactions.

Re:GitHub is investigating an incident with Pull Requests, I... by stabbles on Monday November 27, 2023 @04:29PM (#38438623)
Before this gets downvoted, are there any notable features that could only have been added thanks to the Microsoft acquisition?

I think GitHub actions are pretty successful, which may not have been developed by Microsoft as it was launched right after acquisition, but I guess it's easier to keep free since it runs on their own hardware.

I don't immediately see copilot as a GitHub feature, but maybe that'll change for better or worse.

Re:GitHub is investigating an incident with Pull Requests, I... by johnfn on Monday November 27, 2023 @04:40PM (#38438780)
I think you're asking a slightly incorrect question. Very few features could "only" be added thanks to the MS acquisition. What you really want to know is how many more features were added, thanks to MS. Or, how much longer would those features have taken to be built if GitHub was not acquired by MS. My gut feeling, seeing GH pre- and post-acquisition, says that a lot of the stuff they shipped post-MS would simply never have been shipped before.

Under MS, they shipped - just off the top of my head:

* dev containers

* vscode-github-in-the-browser

* github actions

* that extremely useful fuzzy-find that repos have (press t in any repo)

* copilot

I seriously doubt they could have shipped a single one of those things pre-MS.

Re:GitHub is investigating an incident with Pull Requests, I... by thedaly on Monday November 27, 2023 @05:46PM (#38439587)
> * that extremely useful fuzzy-find that repos have (press t in any repo)

I didn't know this. Thanks for the tip!

Re:GitHub is investigating an incident with Pull Requests, I... by jorams on Wednesday November 29, 2023 @02:10AM (#38456460)
> * that extremely useful fuzzy-find that repos have (press t in any repo)

They shipped that in 2011[1]

[1]: https://github.blog/2011-02-10-introducing-the-file-finder/

Re:GitHub is investigating an incident with Pull Requests, I... by johnfn on Wednesday November 29, 2023 @01:21PM (#38463035)
Fair, though I think it became a lot more useful and usable after the acquisition.
Re:GitHub is investigating an incident with Pull Requests, I... by mook on Monday November 27, 2023 @04:46PM (#38438869)
GitHub Actions seems to use Azure a lot under the hood; given that they seemed to use AWS for older features (attachments, releases, etc.) it seems likely that it actually needed Microsoft.

My best guess, with no knowledge of what actually happened, is that it was derived from Azure Pipelines.

Re:GitHub is investigating an incident with Pull Requests, I... by ad404b8a372f2b9 on Monday November 27, 2023 @04:26PM (#38438566)
That's not true. Reactions on comments were implemented long before the acquisition. And people still did +1.

On the other hand, what they didn't have was search locked behind a login screen.

Re:GitHub is investigating an incident with Pull Requests, I... by mdekkers on Monday November 27, 2023 @11:33PM (#38442365)
> Before the MS acquisition, Github didn't even have emoji reactions.

I have never, ever in my professional life thought “I need an emoji for this”