Re:Of GitHub and Pull Requests (and comics)
by lysium on Saturday April 14, 2012 @04:40PM
(#3841931)
Does not only happen with GitHub and pull requests, but in any open source project, I guess.
I've recently submitted a patch to the mercurial-dev list (as requested). The answer was positive but asked for tests and a better commit message.
Few days later, when I had time to fulfill the request, I found out that one of the main developers fixed the issue in a different way, with an unrelated commit message and with no tests.
Most probably he did not even notice my patch attempt on the mailing list. I guess this happens all the time in every OS project. I still found this discouraging.
I've recently submitted a patch to the mercurial-dev list (as requested). The answer was positive but asked for tests and a better commit message.
Few days later, when I had time to fulfill the request, I found out that one of the main developers fixed the issue in a different way, with an unrelated commit message and with no tests.
Most probably he did not even notice my patch attempt on the mailing list. I guess this happens all the time in every OS project. I still found this discouraging.