News for hackers. Stuff that matters.

A comment on Large pull requests slow down development.

Re:Large pull requests slow down development by d_sem on Tuesday November 21, 2023 @08:46PM (#38373533)
The key is to define the term "large" in this context. Pull requests size is an artifact of a humans brain ability to process changes. Therefore its best to tailor the content of a PR based on how difficult you think it is for the stakeholders you are merging can understand the change. "large" is more a measure of complexity.

When I make changes to a codebase that very few people are experts in and is generally perceived to be difficult to understand, I make "smaller" pull requests so that the change log is followable and changes easier revert.

As with many things in software development: be pragmatic, think of others, and do the best you can.

[ Parent | on HN ]
Re:Large pull requests slow down development by k_dumez on Tuesday November 21, 2023 @08:56PM (#38373631)
> When I make changes to a codebase that very few people are experts in and is generally perceived to be difficult to understand,

Not trying to be snarky, genuinely curious, is this a situation you find yourself in very often? Are you describing something while working at a company or in an open-source project?

[ Parent | on HN ]
Re:Large pull requests slow down development by mock-possum on Wednesday November 22, 2023 @02:17PM (#38383776)
Yeah I will always advocate for smaller, more easily digestible PRs - but the underlying principle is good old “know your audience.”
[ Parent | on HN ]